-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tables.py into several files #139
base: master
Are you sure you want to change the base?
Conversation
Also, remove the test alphabetical order
This pull requests violates part of PEP 423 (the db package has another package inside it) |
|
I also don't think PEP 423 is relevant. It is very far from being a collection of accepted best practices. That said, I don't think this PR is useful. It has bit-rotted, and in case a a new category of tables needs to be added, recreating it might actually be easier than rebasing. Feel free to re-open if you disagree. |
@encukou I think it's still worth doing. Would you mind opening an issue? |
Ah, OK. Then it's probably better as a PR, with a code example. |
This PR is three years old because nobody is here to work on this project. The only way to solve this problem is if there were more people working on it. |
Granted. It's one of my continuing sources of sadness that i don't have
more time to contribute to veekun.
|
This splits off the Conquest tables into their own file.
Sanky's planned maps can also go into their own file.